Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arkworks dependencies for improved deserialization of group elements #84

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

tess-eract
Copy link
Contributor

Integrates Arkworks PR #771, which omits an expensive and unnecessary check when deserializing group elements. This check ensures that a curve point is in the correct prime-order subgroup by multiplying it by the scalar field's modulus. This is not needed when using prime-order elliptic curve groups, as is the case for bn254, grumpkin, and any curve that occurs as part of a cycle.

@tess-eract tess-eract marked this pull request as ready for review February 23, 2024 19:50
@tess-eract tess-eract force-pushed the dorebell-deserialize-arkworks branch from bae4d53 to 7c3b725 Compare February 23, 2024 19:51
@slumber
Copy link
Contributor

slumber commented Feb 23, 2024

k=16 impl=seq

$ cargo nexus prove
    Finished release [optimized] target(s) in 0.01s
Executing program...

---vvv--- program output, if any ---vvv---
Hello, World!

---^^^--- program output, if any ---^^^---

Executed 48 instructions in 522.168µs. 18952 bytes used by trace.
  Loading public parameters ... 3.6s
 Finished in 3.6s
  Computing step 0 ... 666ms
  Computing step 1 ... 585ms
  Computing step 2 ... 614ms
     Proved 3 step(s) in 1.9s; 25.71 instructions / second
  Saving proof ... 52ms
Finished in 52ms

@slumber slumber merged commit 686314e into main Feb 23, 2024
4 checks passed
@slumber slumber deleted the dorebell-deserialize-arkworks branch February 23, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants