Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move conda environment to yml #4079

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Move conda environment to yml #4079

merged 6 commits into from
Oct 24, 2023

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Oct 17, 2023

Closes #4078

@edmundmiller edmundmiller marked this pull request as ready for review October 18, 2023 16:20
@edmundmiller edmundmiller requested a review from a team October 24, 2023 02:42
@edmundmiller
Copy link
Contributor Author

edmundmiller commented Oct 24, 2023

Okay I have the changes for all of the modules locally. I'm not pushing it up yet because I don't want another PR with 100 reviewers 😬 https://github.com/Emiller88/modules/commit/5ca19f5ccb93da671323a9864f1aca30a5af231b

@edmundmiller
Copy link
Contributor Author

Merging sorry for all the requests 😬

@ajtock
Copy link

ajtock commented Oct 30, 2023

Hi @emiller88

Would it be valid to make the conda directive path absolute rather than relative by adding "${projectDir}/" (e.g., conda "${projectDir}/modules/nf-core/trimgalore/environment.yml")? I encountered a potential issue when running a pipeline locally, where the relative path can be resolved only if the launch directory is the project directory containing modules/. I'm not too familiar with nf-test yet, but is it possible that adding "${projectDir}/" to the path might also fix Process relative paths aren't resolved correctly askimed/nf-test#146?

Thanks!
Andy

@nvnieuwk
Copy link
Contributor

I think this is a better solution for the whole pipeline runs, but it doesn't fix nf-test since it creates a small pseudo workflow to test the process. That pipeline is located in the .nf-test folder so the $projectDir is there instead of the top folder. this will need a change in nf-test to work

@grst
Copy link
Member

grst commented Oct 31, 2023

what about "${moduleDir}/environment.yaml"?

@nvnieuwk
Copy link
Contributor

Wow this works! Thanks for the suggestion @grst !!

@nvnieuwk
Copy link
Contributor

Fix PR: #4252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move conda to yaml env files
6 participants