Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gene symbols to merged output #564

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Add gene symbols to merged output #564

merged 3 commits into from
Feb 19, 2021

Conversation

lpantano
Copy link
Contributor

@lpantano lpantano commented Feb 5, 2021 •
edited
Loading

Change of tximport R script to add the rowData columns to the TSV files to add the nice gene names there.

Thanks @grst
#561

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • CHANGELOG.md is updated.

@lpantano lpantano mentioned this pull request Feb 5, 2021
Closed
@lpantano lpantano marked this pull request as ready for review February 8, 2021 17:43
grst
grst reviewed Feb 9, 2021
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this version with gencode annotations on my data and I'm getting the expected results now 🎉

bin/salmon_summarizedexperiment.r Show resolved Hide resolved
grst
grst approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue so quickly 🚀
LGTM now!

@lpantano
Copy link
Contributor Author

@drpatelh, not sure why the test is still in yellow. Let me know if you think all good, or it needs any changes. Thanks!

@drpatelh
Copy link
Member

Will have a look tomorrow. Thanks!

@drpatelh
Copy link
Member

Looks great! Thanks @lpantano !

@drpatelh drpatelh merged commit 8adc44c into dev Feb 19, 2021
@ewels ewels deleted the lpantano_patch_561 branch March 24, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh left review comments

@grst grst grst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpantano @drpatelh @grst