Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display sentieon dedup metrics in multiqc #1123

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Display sentieon dedup metrics in multiqc #1123

merged 6 commits into from
Jun 21, 2023

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Jun 21, 2023 •
edited
Loading

Importing and displaying metrics from Sentieon-Dedup as "custom content" in the MultiQC report.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit aa1ce9a

+| ✅ 154 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-21 16:18:21

@asp8200 asp8200 marked this pull request as ready for review June 21, 2023 15:25
@asp8200 asp8200 requested a review from maxulysse June 21, 2023 15:25
maxulysse
maxulysse reviewed Jun 21, 2023
View reviewed changes
modules.json Outdated Show resolved Hide resolved
@asp8200 @maxulysse
Update modules.json
b3352ac 
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
@asp8200 asp8200 requested a review from maxulysse June 21, 2023 16:13
maxulysse
maxulysse reviewed Jun 21, 2023
View reviewed changes
modules.json Outdated Show resolved Hide resolved
@asp8200 @maxulysse
Update modules.json
aa1ce9a 
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
@asp8200 asp8200 merged commit e3c16f6 into sentieon Jun 21, 2023
@asp8200 asp8200 deleted the display_sentieon_dedup_metrics_in_multiqc branch June 21, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
sentieon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asp8200 @maxulysse @edmundmiller