Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for 2.6 release #131

Merged
merged 16 commits into from
Feb 28, 2020
Merged

Prepare for 2.6 release #131

merged 16 commits into from
Feb 28, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

  • Prepare for the 2.6 release that would be the last one before DSL 2

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse added the release This PR is for a release label Feb 27, 2020
@maxulysse maxulysse added this to the 2.6 milestone Feb 27, 2020
@maxulysse maxulysse requested review from ggabernet and a team February 27, 2020 13:13
@maxulysse maxulysse self-assigned this Feb 27, 2020
@maxulysse
Copy link
Member Author

@ggabernet I tried to refactor the ASCAT process to simplify it. I just tested it and it worked on our server :-D

@maxulysse maxulysse marked this pull request as ready for review February 28, 2020 08:06
apeltzer
apeltzer approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch with all the missing cookiecutter statements 👍

@maxulysse maxulysse added update Tool update and removed work in progress labels Feb 28, 2020
@maxulysse
Copy link
Member Author

LGTM, nice catch with all the missing cookiecutter statements +1

I just noticed it with a CI test that failed for random reason.

But now I'm wondering if there's more around, I'll do a quick check now

@maxulysse
Copy link
Member Author

ok, it looks like there's no cookiecutter statements left anywhere.
It could be a good idea to have nf-core lint check for that.

ggabernet
ggabernet approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxulysse maxulysse mentioned this pull request Feb 28, 2020
Closed
@maxulysse maxulysse merged commit 23a0483 into nf-core:dev Feb 28, 2020
@maxulysse maxulysse deleted the prepare2.6 branch February 28, 2020 08:19
@maxulysse maxulysse mentioned this pull request Mar 1, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

@apeltzer apeltzer apeltzer approved these changes

Assignees

@maxulysse maxulysse

Labels
release This PR is for a release update Tool update
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @apeltzer @ggabernet