Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates on DSL2 #257

Merged
merged 13 commits into from
Jul 29, 2020
Merged

updates on DSL2 #257

merged 13 commits into from
Jul 29, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from drpatelh July 24, 2020 09:58
@maxulysse maxulysse marked this pull request as draft July 24, 2020 09:59
drpatelh
drpatelh approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couple of minor amendments I spotted.

main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
modules/local/subworkflow/build_indices.nf Outdated Show resolved Hide resolved
@maxulysse maxulysse marked this pull request as ready for review July 29, 2020 16:40
@FriederikeHanssen FriederikeHanssen merged commit f04833a into nf-core:dsl2 Jul 29, 2020
@maxulysse maxulysse deleted the dsl2_updates branch October 16, 2020 08:48
@maxulysse maxulysse added the DSL2 label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @FriederikeHanssen @drpatelh