Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #293

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Fix typo #293

merged 2 commits into from
Oct 16, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

close #292

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team October 16, 2020 08:22
@maxulysse maxulysse self-assigned this Oct 16, 2020
@maxulysse maxulysse linked an issue Oct 16, 2020 that may be closed by this pull request
small bug in main.nf line 439 #292
Closed
FriederikeHanssen
FriederikeHanssen approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxulysse maxulysse merged commit e565082 into nf-core:dev Oct 16, 2020
@maxulysse maxulysse deleted the dev_issue292 branch October 16, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees

@maxulysse maxulysse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

small bug in main.nf line 439
2 participants
@maxulysse @FriederikeHanssen