Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VCF QC #522

Merged
merged 12 commits into from
Apr 21, 2022
Merged

Add VCF QC #522

merged 12 commits into from
Apr 21, 2022

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@@ -63,13 +63,18 @@ workflow RUN_STRELKA_SINGLE {
strelka_genome_vcf.no_intervals,
strelka_vcf.no_intervals)

strelka_vcf_out = strelka_vcf.map{ meta, vcf ->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxulysse I was thinking like so

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review April 21, 2022 11:27
@FriederikeHanssen
Copy link
Contributor Author

@maxulysse there is a problem with intervals files that showed up in the MQC report. I started working on it a tiny bit but realised that it should better go in a separate PR

@FriederikeHanssen
Copy link
Contributor Author

Results of running nf-core lint locally:


INFO     Testing pipeline: .                                                                                        __init__.py:243
╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ General lint results                                                                                                            │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [?] 4 Tests Ignored                                                                                                             │
├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ files_unchanged: File ignored due to lint config: assets/nf-core-sarek_logo_light.png                                           │
│ files_unchanged: File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png                                      │
│ files_unchanged: File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png                                       │
│ files_unchanged: File ignored due to lint config: lib/NfcoreTemplate.groovy                                                     │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [!] 7 Test Warnings                                                                                                             │
├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ pipeline_todos: TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required                           │
│ pipeline_todos: TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or direct… │
│ pipeline_todos: TODO string in test_full.config: Give any required params for the test so that command line flags are not need… │
│ pipeline_todos: TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or direct… │
│ pipeline_todos: TODO string in test_full.config: Give any required params for the test so that command line flags are not need… │
│ schema_description: No description provided in schema for parameter: umi_read_structure                                         │
│ schema_description: No description provided in schema for parameter: group_by_umi_strategy                                      │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [✗] 3 Tests Failed                                                                                                              │
├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ files_unchanged: .github/workflows/branch.yml does not match the template                                                       │
│ files_unchanged: .github/workflows/linting_comment.yml does not match the template                                              │
│ files_unchanged: .github/workflows/linting.yml does not match the template                                                      │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Module lint results                                                                                                             │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ [!] 1 Test Failed                                                                                                               │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭──────────────────────────────────────────┬───────────────────────────────────────┬──────────────────────────────────────────────╮
│ Module name                              │ File path                             │ Test message                                 │
├──────────────────────────────────────────┼───────────────────────────────────────┼──────────────────────────────────────────────┤
│ ascat                                    │ modules/nf-core/modules/ascat/main.nf │ Local copy of module does not match remote   │
╰──────────────────────────────────────────┴───────────────────────────────────────┴──────────────────────────────────────────────╯
╭───────────────────────╮
│ LINT RESULTS SUMMARY  │
├───────────────────────┤
│ [✔] 431 Tests Passed  │
│ [?]   4 Tests Ignored │
│ [!]   7 Test Warnings │
│ [✗]   4 Tests Failed  │
╰───────────────────────╯

Tip: Some of these linting errors can automatically be resolved with the following command:

    nf-core lint  --fix files_unchanged
    ```
    

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful

@maxulysse maxulysse merged commit 2aaaa35 into nf-core:dev Apr 21, 2022
@FriederikeHanssen FriederikeHanssen deleted the add_qc branch July 10, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants