Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More polish #752

Merged
merged 3 commits into from
Sep 16, 2022
Merged

More polish #752

merged 3 commits into from
Sep 16, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

maxulysse referenced this pull request Sep 16, 2022
@maxulysse
Merge pull request #731 from FriederikeHanssen/aws_fullsize
9f08fd8 
switch germline and somatic full tests
@github-actions
Copy link

github-actions bot commented Sep 16, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 3eaa57a

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.5.1
  • Run at 2022-09-16 11:15:06

ggabernet
ggabernet approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@maxulysse @ggabernet
Update CHANGELOG.md
3eaa57a 
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@maxulysse maxulysse merged commit 7339521 into nf-core:dev Sep 16, 2022
@maxulysse maxulysse deleted the dev_polish branch September 16, 2022 11:57
@maxulysse maxulysse mentioned this pull request Sep 26, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @ggabernet