Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CHANGELOG #760

Merged
merged 1 commit into from
Sep 26, 2022
Merged

update CHANGELOG #760

merged 1 commit into from
Sep 26, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

FriederikeHanssen
FriederikeHanssen reviewed Sep 26, 2022
View reviewed changes
CHANGELOG.md
@@ -231,7 +233,7 @@ Skierfe is a mountain in the Sarek national park, and the inspiration for the lo
| `bwa` | 0.7.17 | unchanged |
| `cancerit-allelecount` | 4.0.2 | 4.3.0 |
| `cnvkit` | 0.9.6 | 0.9.9 |
| `control-freec` | 11.6 | 11.6 |
| `control-freec` | 11.6 | unchanged |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never realised you put in the list 🤯 ❤️ should the header be 3.0.2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did that with #752
And no, because actually this is what modules were update in 3.0 (no modules updates (or no version updated to be exact) in 3.0.1 or 3.0.2)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok makes sense

@github-actions
Copy link

github-actions bot commented Sep 26, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 0bc8953

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.5.1
  • Run at 2022-09-26 07:47:57

@maxulysse maxulysse merged commit 2d1d658 into nf-core:dev Sep 26, 2022
@maxulysse maxulysse deleted the dev_CHANGELOG_fix branch September 26, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen