Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

211 samplesheet error in v220 when more than 3 fields are present #216

Merged
merged 4 commits into from
Apr 11, 2023
Merged

211 samplesheet error in v220 when more than 3 fields are present #216

merged 4 commits into from
Apr 11, 2023

Conversation

fmalmeida
Copy link
Contributor

@fmalmeida fmalmeida commented Mar 28, 2023 •
edited
Loading

Solves #211 which had a wrong checking on required columns in samplesheet

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@fmalmeida fmalmeida linked an issue Mar 28, 2023 that may be closed by this pull request
Samplesheet error in v2.2.0 when more than 3 fields are present #211
Closed
@github-actions
Copy link

github-actions bot commented Mar 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit e91d750

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-28 13:30:57

@fmalmeida fmalmeida requested a review from grst March 31, 2023 10:46
@fmalmeida fmalmeida marked this pull request as ready for review March 31, 2023 10:46
grst
grst approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fmalmeida
Copy link
Contributor Author

I will merge this one. If anything more related to it appears, we can open a new ticket or comment in the related PR/ticket.

@fmalmeida fmalmeida merged commit 4bf9061 into dev Apr 11, 2023
@fmalmeida fmalmeida deleted the 211-samplesheet-error-in-v220-when-more-than-3-fields-are-present branch April 11, 2023 11:16
@rhodesch rhodesch mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Samplesheet error in v2.2.0 when more than 3 fields are present
2 participants
@fmalmeida @grst