-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE PR for 2.3.0 release] #305
Conversation
Added additional configuration to change the output file name of samtools sort.
Added the documentation detailing the output files of the UMI-tools deduplication step.
After deduplication the reads that remained unaligned to the provided reference genome are merged with the set of deduplicated reads to enable the use of the full spectrum of reads, independent of potential reference bias. This behaviour can be deactivated by setting --umi_merge_unmapped false
Information on the new --umi_merge_unmapped command were added to both the CHANGELOG, as well as the output markdown script.
Includes the nf-core cat module to replace the custom concatenation module.
Implements the use of the nf-core cat module.
deletes the now unused conatenation module.
Fix bowtie index issue
…-2.13Apply chris changes on top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with first 100 files, will continue later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :), although I've not had a look at everything so please don't take my review as a full review
Co-authored-by: Christopher Mohr <contact.cmohr@gmail.com>
Will also wait for @christopher-mohr 's final words. And running a few combination tests locally on our HPC to be safe. These few hours are not going to hurt anymore ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR checklist
Full Changelog:
v2.3.0 - 2024-02-23 - Gray Zinc Dalmatian
genome_quant.r
)three_prime_adapter
per defaultParameters
--with_umi
--umitools_extract_method
--umitools_method
--skip_umi_extract
--umitools_bc_pattern
--umi_discard_read
--save_umi_intermeds
--save_aligned
--save_aligned_mirna_quant
--save_merged
Software dependencies
multiqc
edgeR
limma
bioconvert
mirdeep
seqkit
fastqc
samtools
umitools
umicollapse
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).