Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mirtrace staging bug #335

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Fix mirtrace staging bug #335

merged 5 commits into from
Apr 3, 2024

Conversation

apeltzer
Copy link
Member

@apeltzer apeltzer commented Apr 3, 2024

This addresses the staging / casting issue first identified in the issue #327

The previous fix ignored the possibility that (depending on the platform), directly referencing work directories can cause trouble as there is no guarantee that these are staged properly to the work dir of mirtrace. This is resolved by reverting to the previously working approach with mirtrace where the files are staged to the same directory, then adding functionality to use the filename(s) of provided files in the work dir of mirtrace directly instead. This ensures nextflow is aware of any files being staged to mirtrace, thus guaranteeing that files are properly staged.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@apeltzer apeltzer changed the base branch from master to dev April 3, 2024 08:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @apeltzer,

It looks like this pull-request is has been made against the nf-core/smrnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/smrnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5d3b78f

+| ✅ 181 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-03 08:56:43

grst
grst approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The filenames per sample are unique, right? So we shouldn't get any issues from staging them into the same directory.

@apeltzer apeltzer marked this pull request as ready for review April 3, 2024 08:54
@apeltzer
Copy link
Member Author

apeltzer commented Apr 3, 2024

LGTM

The filenames per sample are unique, right? So we shouldn't get any issues from staging them into the same directory.

Yes, they are - this should be fine 👍🏻

@apeltzer apeltzer merged commit 18d4eba into dev Apr 3, 2024
10 checks passed
@apeltzer apeltzer deleted the fix-mirtrace-staging-bug branch April 3, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

@christopher-mohr christopher-mohr Awaiting requested review from christopher-mohr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeltzer @grst @fmalmeida