Merge pull request #2323 from mirpedrol/fix-update

don't update modules_json if module is not updated
nf-core · Jun 22, 2023 · 4f32c07 · 4f32c07
2 parents 7b757a7 + fbe8155
commit 4f32c07
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,8 @@
 
 ### Modules
 
+- Don't update `modules_json` object if a module is not updated ([#2323](https://github.com/nf-core/tools/pull/2323))
+
 ### Subworkflows
 
 ### General

diff --git a/nf_core/components/update.py b/nf_core/components/update.py
@@ -306,16 +306,6 @@ def update(self, component=None, silent=False, updated=None, check_diff_exist=Tr
                     # Update linked components
                     self.update_linked_components(modules_to_update, subworkflows_to_update, updated)
                     self.manage_changes_in_linked_components(component, modules_to_update, subworkflows_to_update)
-            else:
-                # Don't save to a file, just iteratively update the variable
-                self.modules_json.update(
-                    self.component_type,
-                    modules_repo,
-                    component,
-                    version,
-                    installed_by=None,
-                    write_file=False,
-                )
 
         if self.save_diff_fn:
             # Write the modules.json diff to the file