-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't update modules_json if module is not updated #2323
Conversation
Hi @ewels, I opened this PR to fix #2014, here I remove the piece of code which updates the The bug in this issue was happening because when we preview differences for all modules, we can choose to not update a module, but the I remember I tried to remove this piece of code a while ago, and you told me it wasn't a good idea, but I can't see a case where we would want to update |
Codecov Report
@@ Coverage Diff @@
## dev #2323 +/- ##
==========================================
- Coverage 72.86% 72.84% -0.02%
==========================================
Files 78 78
Lines 8774 8773 -1
==========================================
- Hits 6393 6391 -2
- Misses 2381 2382 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we change something in the update function that it now writes a file or why does this solve the problem?
I think this bug has always been there, but we only see it if we update all modules, decide not to update one of them, and then continue updating the rest. Because we will change the sha value for the not updated one and write it to the file while updating the others afterwards. |
Close #2014
PR checklist
CHANGELOG.md
is updateddocs
is updated