First stab at writing a central utils function for GitHub API calls. #1499
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Might be worth looking into doing API requests using a shared See also: https://requests-cache.readthedocs.io/en/stable/user_guide/general.html#sessions Could then just define the auth once for the whole run, and might be faster when we're doing a lot of calls to the GitHub API. |
Uses authentication from local gh CLI or a supplied bearer token if found. Done to address nf-core#1496 Bit scared it'll break something, so ideally needs extensive testing.
Also removed function prefix from calls that were in the same file
This comment was marked as resolved.
This comment was marked as resolved.
Leave this for another day I think. Especially as we may rewrite how the modules code works, so drop the number of GitHub API calls that we're doing anyway. |
|
to install locally |
|
Works locally. (lint fails, but we're not hitting limit of API calls anymore) |
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
|
Thank you for the help @mirpedrol! |
Uses authentication from local gh CLI or a supplied bearer token if found.
Done to address #1496
Bit scared it'll break something, so ideally needs extensive testing.
PR checklist
CHANGELOG.mdis updateddocsis updated