Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First stab at writing a central utils function for GitHub API calls. #1499

Merged
merged 13 commits into from
May 11, 2022
Merged

First stab at writing a central utils function for GitHub API calls. #1499

merged 13 commits into from
May 11, 2022

Commits on Apr 6, 2022

  1. First stab at writing a central utils function for GitHub API calls. 

    Uses authentication from local gh CLI or a supplied bearer token if found.

Done to address nf-core#1496

Bit scared it'll break something, so ideally needs extensive testing.
    @ewels
    ewels committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    2d99a43 View commit details
    Browse the repository at this point in the history

  2. Remove superfluous dict() call

    @ewels
    ewels committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b2b7e3b View commit details
    Browse the repository at this point in the history

  3. Fix sync pytests

    @ewels
    ewels committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d516a05 View commit details
    Browse the repository at this point in the history

  4. Better debug logging. 

    Also removed function prefix from calls that were in the same file
    @ewels
    ewels committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    01089e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Try to rewrite GitHub API calls to use a single shared Session

    @ewels
    ewels committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d7e596e View commit details
    Browse the repository at this point in the history

  2. Use new class more in the sync code

    @ewels
    ewels committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    1a453bb View commit details
    Browse the repository at this point in the history

  3. Nearly fix the tests

    @ewels
    ewels committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    868d941 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Merge branch 'master' into actions-auth-api

    @ewels
    ewels committed May 10, 2022
    Configuration menu
    Copy the full SHA
    5ac00d3 View commit details
    Browse the repository at this point in the history

  2. Better exception handling / logging for gh auth failure

    @ewels
    ewels committed May 10, 2022
    Configuration menu
    Copy the full SHA
    ded22cb View commit details
    Browse the repository at this point in the history

  3. Use XDG_CONFIG_HOME or ~/.config/nf-core/ for the requests cache dir. 

    Suggested by @emiller88 👍🏻
    @ewels
    ewels committed May 10, 2022
    Configuration menu
    Copy the full SHA
    58d012b View commit details
    Browse the repository at this point in the history

  4. Changelog

    @ewels
    ewels committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a29fe61 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
    @ewels @mirpedrol
    ewels and mirpedrol authored May 11, 2022
    Configuration menu
    Copy the full SHA
    0f73634 View commit details
    Browse the repository at this point in the history

  2. Update nf_core/sync.py 

    Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
    @ewels @mirpedrol
    ewels and mirpedrol authored May 11, 2022
    Configuration menu
    Copy the full SHA
    40093e0 View commit details
    Browse the repository at this point in the history