-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/teams hook #1798
Feature/teams hook #1798
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1798 +/- ##
=======================================
Coverage 69.25% 69.25%
=======================================
Files 59 59
Lines 7148 7148
=======================================
Hits 4950 4950
Misses 2198 2198 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I haven't updated the changelog yet since there're no new entry available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! But maybe someone with more Groovy knowledge can have a better look 🙂
I'm aware there's a lot of duplicate code with the e-mail function, but I'm not really sure how I would go about cleaning that up in a "groovy" way. |
Perhaps groovy master @mahesh-panchal would care to comment on the groovy part? |
I think the idea is to let Nextflow handle email (see #112), so it's probably not worth it to put a lot of effort into cleaning this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking on that again. Let's merge it and test it on dev if you are happy with it 🙂
Remember to update the CHANGELOG before
Updated the changelog! |
@nf-core-bot fix linting |
This PR adds a config option + function to enable messaging pipeline status updates through Teams
Examples:
PR checklist
CHANGELOG.md
is updateddocs
is updated