Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track from where modules and subworkflows are installed #1999

Merged
merged 16 commits into from
Nov 8, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Nov 4, 2022

Track from where modules and subworkflows are installed.

  • a module installed with nf-core modules install: "modules"
  • a subworkflow installed with nf-core subworkflows install: "subworkflows"
  • a module or subworkflow installed automatically when installing another subworkflow: ""

Updates modules.json file adding a new field installed for every module/subworkflow
💭 With previously installed modules/subworkflows, it assumes they were installed by an nf-core command, without taking into account if they are used by other subworkflows.

I also fix some small bugs that I found on the way.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1999 (a5073fa) into dev (1e36a4f) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##              dev    #1999      +/-   ##
==========================================
- Coverage   63.15%   63.11%   -0.05%     
==========================================
  Files          43       43              
  Lines        4951     4945       -6     
==========================================
- Hits         3127     3121       -6     
  Misses       1824     1824              
Impacted Files Coverage Δ
nf_core/components/components_create.py 74.76% <ø> (-0.24%) ⬇️
nf_core/components/components_install.py 78.84% <75.00%> (-1.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol marked this pull request as ready for review November 4, 2022 15:31
nf_core/modules/modules_json.py Outdated Show resolved Hide resolved
nf_core/modules/modules_json.py Outdated Show resolved Hide resolved
nf_core/modules/modules_json.py Outdated Show resolved Hide resolved
nf_core/subworkflows/install.py Show resolved Hide resolved
nf_core/modules/remove.py Show resolved Hide resolved
nf_core/subworkflows/install.py Show resolved Hide resolved
mirpedrol and others added 3 commits November 8, 2022 09:38
@mirpedrol mirpedrol merged commit 3d0c0cc into nf-core:dev Nov 8, 2022
@mirpedrol mirpedrol deleted the installtrack branch November 8, 2022 09:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants