modules_json create() adds subworkflows #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2005 +/- ##
======================================
Coverage ? 63.11%
======================================
Files ? 43
Lines ? 4945
Branches ? 0
======================================
Hits ? 3121
Misses ? 1824
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mashehu
approved these changes
Nov 8, 2022
tests/modules/modules_json.py
Outdated
| @@ -60,6 +60,7 @@ def test_mod_json_create(self): | |||
| # Get the contents of the file | |||
| mod_json_obj = ModulesJson(self.pipeline_dir) | |||
| mod_json = mod_json_obj.get_modules_json() | |||
| print(mod_json) | |||
There was a problem hiding this comment.
is that print statement still needed?
There was a problem hiding this comment.
no, sorry :)
Suggested change
| print(mod_json) |
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
create()frommodules_json.pyadds also subworkflows tomodules.jsonfile.Merge #1999 first
PR checklist
CHANGELOG.mdis updateddocsis updated