Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template: Fix GitHub Actions CI and Linting badges links #2757

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

RaqManzano
Copy link
Contributor

Fixed GitHub Actions CI and Linting badges links.

mashehu and others added 3 commits January 29, 2024 15:38
Fixed GitHub Actions CI and Linting badges links.
@RaqManzano RaqManzano self-assigned this Feb 15, 2024
@maxulysse maxulysse changed the title Raq manzano patch 1 Fix GitHub Actions CI and Linting badges links Feb 15, 2024
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One minor change - to update the link to the CI runs as well as just the badge.

Also you put the linting comment workflow rather than the linting :) The linting comment CI is the job that posts a comment after linting fails, which is kind of irrelevant. It always passes even if linting is failing.

nf_core/pipeline-template/README.md Outdated Show resolved Hide resolved
nf_core/pipeline-template/README.md Outdated Show resolved Hide resolved
@ewels ewels changed the title Fix GitHub Actions CI and Linting badges links Template: Fix GitHub Actions CI and Linting badges links Feb 15, 2024
@ewels

This comment was marked as resolved.

nf_core/pipeline-template/README.md Outdated Show resolved Hide resolved
@mashehu mashehu merged commit 2224747 into nf-core:dev Feb 16, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants