-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added -profile wave
to the template.
#2941
Conversation
If someone could add this into upstream pipelines to be sure we're not going to hit any unexpected errors, that'd be fab. Maybe Sarek @maxulysse @FriederikeHanssen, and rnaseq someone else, at least? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
I'll have a look at adding that in both in POC PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not working as expected
working locally: nf-core/rnaseq#1291 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
We need docs for it, plus bumping the minimal Nextflow version |
This comment was marked as off-topic.
This comment was marked as off-topic.
apptainer.ociAutoPull = true | ||
singularity.ociAutoPull = true | ||
wave.enabled = true | ||
wave.freeze = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see in the documentation that we would need to provide wave.build.repository
together with wave.freeze = true
. Is it required? Would it be safer to let users provide both parameters.
Add a config profile in the template to use Wave.
Note
Requires
24.03.0-edge
! I considered bumpingnextflowVersion
to24.04.0
but it feels a bit overkill when the vast majority of end users will not be using-profile wave
. I'm inclined to mention this in the docs but not encode it in the config. Please shout if you disagree.Will need more docs about Wave, but that's a larger effort, probably for the website repo.
PR checklist
CHANGELOG.md
is updateddocs
is updated