Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent failing test helper #4432

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix intermittent failing test helper #4432

merged 1 commit into from
Sep 27, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Sep 27, 2023

Proposed changes

Remove parallelisation from the healthcheck package tests.

The parallelisation is removed to avoid the intermittent port binding issues in the test helper responsible for staring a new test server.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner September 27, 2023 09:40
@github-actions github-actions bot added the tests Pull requests that update tests label Sep 27, 2023
@jjngx jjngx linked an issue Sep 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4432 (0183040) into main (9dcd4cc) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4432      +/-   ##
==========================================
- Coverage   52.12%   52.09%   -0.03%     
==========================================
  Files          59       59              
  Lines       16956    16956              
==========================================
- Hits         8838     8834       -4     
- Misses       7821     7823       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx self-assigned this Sep 27, 2023
@jjngx jjngx merged commit 0fb6f91 into main Sep 27, 2023
62 checks passed
@jjngx jjngx deleted the test/healthcheck branch September 27, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Port binding issue in the healthcheck package tests
3 participants