Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intermittent failing test helper #4432

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix intermittent failing test helper #4432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions internal/healthcheck/healthcheck_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ func newTestHealthServer(t *testing.T) *healthcheck.HealthServer {
}

func TestHealthCheckServer_Returns404OnMissingHostname(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.UpstreamsForHost = getUpstreamsForHost
hs.NginxUpstreams = getUpstreamsFromNGINXAllUp
Expand All @@ -66,8 +64,6 @@ func TestHealthCheckServer_Returns404OnMissingHostname(t *testing.T) {
}

func TestHealthCheckServer_ReturnsCorrectStatsForHostnameOnAllPeersUp(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.UpstreamsForHost = getUpstreamsForHost
hs.NginxUpstreams = getUpstreamsFromNGINXAllUp
Expand Down Expand Up @@ -97,8 +93,6 @@ func TestHealthCheckServer_ReturnsCorrectStatsForHostnameOnAllPeersUp(t *testing
}

func TestHealthCheckServer_ReturnsCorrectStatsForHostnameOnAllPeersDown(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.UpstreamsForHost = getUpstreamsForHost
hs.NginxUpstreams = getUpstreamsFromNGINXAllUnhealthy
Expand Down Expand Up @@ -129,8 +123,6 @@ func TestHealthCheckServer_ReturnsCorrectStatsForHostnameOnAllPeersDown(t *testi
}

func TestHealthCheckServer_ReturnsCorrectStatsForValidHostnameOnPartOfPeersDown(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.UpstreamsForHost = getUpstreamsForHost
hs.NginxUpstreams = getUpstreamsFromNGINXPartiallyUp
Expand Down Expand Up @@ -161,8 +153,6 @@ func TestHealthCheckServer_ReturnsCorrectStatsForValidHostnameOnPartOfPeersDown(
}

func TestHealthCheckServer_RespondsWith404OnNotExistingHostname(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.UpstreamsForHost = getUpstreamsForHost
hs.NginxUpstreams = getUpstreamsFromNGINXNotExistingHost
Expand All @@ -179,8 +169,6 @@ func TestHealthCheckServer_RespondsWith404OnNotExistingHostname(t *testing.T) {
}

func TestHealthCheckServer_RespondsWith500OnErrorFromNGINXAPI(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.UpstreamsForHost = getUpstreamsForHost
hs.NginxUpstreams = getUpstreamsFromNGINXErrorFromAPI
Expand All @@ -197,8 +185,6 @@ func TestHealthCheckServer_RespondsWith500OnErrorFromNGINXAPI(t *testing.T) {
}

func TestHealthCheckServer_Returns404OnMissingTransportServerActionName(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.StreamUpstreamsForName = streamUpstreamsForName
hs.NginxStreamUpstreams = streamUpstreamsFromNGINXAllUp
Expand All @@ -215,8 +201,6 @@ func TestHealthCheckServer_Returns404OnMissingTransportServerActionName(t *testi
}

func TestHealthCheckServer_Returns404OnBogusTransportServerActionName(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.StreamUpstreamsForName = streamUpstreamsForName
hs.NginxStreamUpstreams = streamUpstreamsFromNGINXAllUp
Expand All @@ -233,8 +217,6 @@ func TestHealthCheckServer_Returns404OnBogusTransportServerActionName(t *testing
}

func TestHealthCheckServer_ReturnsCorrectTransportServerStatsForNameOnAllPeersUp(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.StreamUpstreamsForName = streamUpstreamsForName
hs.NginxStreamUpstreams = streamUpstreamsFromNGINXAllUp
Expand Down Expand Up @@ -264,8 +246,6 @@ func TestHealthCheckServer_ReturnsCorrectTransportServerStatsForNameOnAllPeersUp
}

func TestHealthCheckServer_ReturnsCorrectTransportServerStatsForNameOnSomePeersUpSomeDown(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.StreamUpstreamsForName = streamUpstreamsForName
hs.NginxStreamUpstreams = streamUpstreamsFromNGINXPartiallyUp
Expand Down Expand Up @@ -295,8 +275,6 @@ func TestHealthCheckServer_ReturnsCorrectTransportServerStatsForNameOnSomePeersU
}

func TestHealthCheckServer_ReturnsCorrectTransportServerStatsForNameOnAllPeersDown(t *testing.T) {
t.Parallel()

hs := newTestHealthServer(t)
hs.StreamUpstreamsForName = streamUpstreamsForName
hs.NginxStreamUpstreams = streamUpstreamsFromNGINXAllPeersDown
Expand Down