Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix retries in tests #4801

Merged
merged 2 commits into from
Dec 14, 2023
Merged

fix retries in tests #4801

merged 2 commits into from
Dec 14, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Dec 14, 2023 •
edited

Proposed changes

  • fix retries in tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner December 14, 2023 16:15
@github-actions github-actions bot added the tests Pull requests that update tests label Dec 14, 2023
@vepatel vepatel merged commit e88a4f2 into main Dec 14, 2023
71 checks passed
@vepatel vepatel deleted the tests/fix-retries branch December 14, 2023 16:55
jjngx pushed a commit that referenced this pull request Dec 15, 2023
@vepatel @jjngx
fix retries in tests (#4801)
3e9e267
jjngx added a commit that referenced this pull request Dec 15, 2023
@jjngx @vepatel
fix retries in tests (#4801) (#4806)
b048376 
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vepatel @oseoin @j1m-ryan @jjngx @shaun-nx