Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retries in tests (#4801) #4806

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix retries in tests (#4801) #4806

merged 2 commits into from
Dec 15, 2023

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Dec 15, 2023

Proposed changes

Cherry pick from the main branch - fix for tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner December 15, 2023 11:16
@github-actions github-actions bot added bug An issue reporting a potential bug tests Pull requests that update tests labels Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (604d1db) 52.01% compared to head (e0e88fd) 52.01%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.4    #4806   +/-   ##
============================================
  Coverage        52.01%   52.01%           
============================================
  Files               60       60           
  Lines            17313    17313           
============================================
  Hits              9005     9005           
  Misses            7995     7995           
  Partials           313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx merged commit b048376 into release-3.4 Dec 15, 2023
65 checks passed
@jjngx jjngx deleted the fix/retries branch December 15, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants