-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/telemetry platform #5217
Merged
Merged
Feat/telemetry platform #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaun-nx
reviewed
Mar 8, 2024
vepatel
reviewed
Mar 8, 2024
This PR adds support for Exporter telemetry data; decouples NIC internal data from imported Exporter data
I0311 17:22:40.840321 1 collector.go:87] Collecting telemetry data
I0311 17:22:40.861822 1 collector.go:114] Exported telemetry data: {Data:{ProjectName:NIC ProjectVersion:3.5.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:c232007d-76bf-48a5-8dc2-60e017467f0f ClusterVersion:v1.29.2 ClusterPlatform:kind InstallationID: ClusterNodeCount:1} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0}} |
pdabelf5
approved these changes
Mar 12, 2024
shaun-nx
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds Platform to telemetry data. The k8s platform or a cloud provider is determined by checking the
platformID
field.If the ProviderID value is present, it is added to the telemetry payload in the original form (in lower case). If the
ProviderID
is not present, the valueother
is used and added to the telemetry payload.This approach allows reporting actual values used by cloud/platform vendors. It also decouples vendor's changes from NIC codebase.
kind
example:Checklist
Before creating a PR, run through this checklist and mark each as complete.