Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/telemetry platform #5217

Merged
merged 13 commits into from
Mar 12, 2024
Merged

Feat/telemetry platform #5217

merged 13 commits into from
Mar 12, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 7, 2024

Proposed changes

This PR adds Platform to telemetry data. The k8s platform or a cloud provider is determined by checking the platformID field.

If the ProviderID value is present, it is added to the telemetry payload in the original form (in lower case). If the ProviderID is not present, the value other is used and added to the telemetry payload.

This approach allows reporting actual values used by cloud/platform vendors. It also decouples vendor's changes from NIC codebase.

kind example:

I0307 19:31:31.619500       1 collector.go:85] Collecting telemetry data
I0307 19:31:31.650602       1 collector.go:94] Exported telemetry data: {ProjectMeta:{Name:NIC Version:3.5.0-SNAPSHOT} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0} NodeCount:1 ClusterID:c232007d-76bf-48a5-8dc2-60e017467f0f K8sVersion:v1.29.2 Arch:amd64 Platform:kind}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner March 7, 2024 19:33
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Mar 7, 2024
@jjngx jjngx linked an issue Mar 7, 2024 that may be closed by this pull request
jjngx and others added 4 commits March 8, 2024 14:04
This PR adds support for Exporter telemetry data; decouples NIC internal data from imported Exporter data
@jjngx
Copy link
Contributor Author

jjngx commented Mar 11, 2024

I0311 17:22:40.840321       1 collector.go:87] Collecting telemetry data
I0311 17:22:40.861822       1 collector.go:114] Exported telemetry data: {Data:{ProjectName:NIC ProjectVersion:3.5.0-SNAPSHOT ProjectArchitecture:amd64 ClusterID:c232007d-76bf-48a5-8dc2-60e017467f0f ClusterVersion:v1.29.2 ClusterPlatform:kind InstallationID: ClusterNodeCount:1} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0}}

@jjngx jjngx merged commit 3e459f7 into main Mar 12, 2024
77 checks passed
@jjngx jjngx deleted the feat/telemetry-platform branch March 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect deployment platform
4 participants