Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix api key policy undefined routes #5838

Merged
merged 6 commits into from
Jun 25, 2024
Merged

fix api key policy undefined routes #5838

merged 6 commits into from
Jun 25, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner June 24, 2024 16:09
@github-actions github-actions bot added bug An issue reporting a potential bug python Pull requests that update Python code tests Pull requests that update tests labels Jun 24, 2024
@j1m-ryan j1m-ryan added the needs cherry pick Cherry pick this PR into a release branch label Jun 25, 2024
@oseoin oseoin mentioned this pull request Jun 25, 2024
Merged
6 tasks
@nginx-bot nginx-bot mentioned this pull request Jun 25, 2024
Merged
6 tasks
@github-actions github-actions bot added the go Pull requests that update Go code label Jun 25, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 25, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) June 25, 2024 10:49
@j1m-ryan @vepatel
Update examples/custom-resources/api-key/README.md
3fe951a 
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Signed-off-by: Jim Ryan <j.ryan@f5.com>
@j1m-ryan j1m-ryan merged commit dec3524 into main Jun 25, 2024
80 checks passed
@j1m-ryan j1m-ryan deleted the fix/apikey-undefined-routes branch June 25, 2024 11:32
nginx-bot pushed a commit that referenced this pull request Jun 25, 2024
@j1m-ryan @web-flow
fix api key policy undefined routes (#5838)
6364d48 
* fix api key policy undefined routes

* add template test

* update docs
j1m-ryan added a commit that referenced this pull request Jun 25, 2024
@nginx-bot @j1m-ryan
[cherry-pick] fix api key policy undefined routes (#5852)
5faa363 
fix api key policy undefined routes (#5838)

* fix api key policy undefined routes

* add template test

* update docs

Co-authored-by: Jim Ryan <j.ryan@f5.com>
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@j1m-ryan @AlexFenlon
fix api key policy undefined routes (#5838)
2dc6c1b 
* fix api key policy undefined routes

* add template test

* update docs
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug documentation Pull requests/issues for documentation go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uninitialised Warn possible when using API Key policy on server level
6 participants
@j1m-ryan @oseoin @vepatel @AlexFenlon @jjngx @pdabelf5