Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build arg for templates #5844

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Fix build arg for templates #5844

merged 3 commits into from
Jun 25, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jun 25, 2024

Proposed changes

Fix for issue found in #5838

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested a review from a team as a code owner June 25, 2024 08:59
@github-actions github-actions bot added the docker Pull requests that update Docker code label Jun 25, 2024
@oseoin oseoin enabled auto-merge (squash) June 25, 2024 09:02
@oseoin oseoin added the needs cherry pick Cherry pick this PR into a release branch label Jun 25, 2024
@oseoin oseoin merged commit df72b9c into main Jun 25, 2024
79 checks passed
@oseoin oseoin deleted the fix-build-arg branch June 25, 2024 09:59
nginx-bot pushed a commit that referenced this pull request Jun 25, 2024
@oseoin @web-flow
Fix build arg for templates (#5844)
b7d5e5c
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@oseoin @AlexFenlon
Fix build arg for templates (#5844)
8e367b6
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
docker Pull requests that update Docker code needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oseoin @j1m-ryan @vepatel @jjngx @pdabelf5