Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream parameters in nginx-asg-sync #30

Closed
wants to merge 10 commits into from

Conversation

bvighnesha
Copy link

@bvighnesha bvighnesha commented Sep 27, 2019

Proposed changes

As a user, I would like to configure upstream server parameters for both http and stream upstreams.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@bvighnesha bvighnesha self-assigned this Sep 27, 2019
@bvighnesha bvighnesha changed the title [WIP] Add upstream parameters in nginx-asg-sync Add upstream parameters in nginx-asg-sync Sep 30, 2019
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Looks good, I have added a few comments/suggestions.

Additionally, we need to add documentation of the new fields here:
https://github.com/nginxinc/nginx-asg-sync/blob/master/examples/aws.md

and here:
https://github.com/nginxinc/nginx-asg-sync/blob/master/examples/azure.md

cmd/sync/azure.go Outdated Show resolved Hide resolved
cmd/sync/validation.go Outdated Show resolved Hide resolved
cmd/sync/main.go Outdated Show resolved Hide resolved
cmd/sync/errormessages.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @b-v-r sorry I missed one thing about max_fails last time I reviewed it, but I think is important we take care of.

Also I suggest to add default values in docs (check my suggestion). Thanks again!

cmd/sync/main.go Outdated Show resolved Hide resolved
examples/aws.md Outdated Show resolved Hide resolved
@bvighnesha bvighnesha requested a review from Rulox October 3, 2019 03:52
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now thanks!

PS: This PR can't be merged until we update the UpdateHTTP method of the go client. Right now it does not perform updates on the Upstream parameters.

Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small comments regarding test style/consistency and structure.

cmd/sync/main_test.go Outdated Show resolved Hide resolved
cmd/sync/main_test.go Outdated Show resolved Hide resolved
cmd/sync/validation_test.go Outdated Show resolved Hide resolved
cmd/sync/validation_test.go Outdated Show resolved Hide resolved
cmd/sync/validation_test.go Outdated Show resolved Hide resolved
cmd/sync/validation_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leading spaces in cmd/sync/main_test.go still look strange to me.
For example:
t.Errorf(" setPositiveInt() -> t.Errorf("setPositiveInt()

Aside from that, this looks ready. - Just need updated UpdateHTTP method from go client to proceed.

@Rulox
Copy link
Contributor

Rulox commented Nov 11, 2019

Closing in favour of #33

@Rulox Rulox closed this Nov 11, 2019
@Rulox Rulox deleted the feature/support_upstream_parameters branch November 11, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants