Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow upstream parameters update #33

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Allow upstream parameters update #33

merged 1 commit into from
Nov 15, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Nov 11, 2019 •
edited

Proposed changes

Now, it is possible to specify and/or update Upstream parameters such as : max_conns, max_fails, fail_timeout and slow_start

Fixes #1

@Rulox Rulox added the enhancement Pull requests for new features/feature enhancements label Nov 11, 2019
@Rulox Rulox mentioned this pull request Nov 11, 2019
Closed
6 tasks
Rulox
Rulox commented Nov 13, 2019
View reviewed changes
examples/aws.md Outdated Show resolved Hide resolved
pleshakov
pleshakov reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rulox thanks. please see a few comments

cmd/sync/errormessages.go Outdated Show resolved Hide resolved
cmd/sync/main.go Outdated Show resolved Hide resolved
Gopkg.lock Show resolved Hide resolved
@Rulox Rulox requested a review from pleshakov November 14, 2019 14:34
pleshakov
pleshakov approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit 722e910 into master Nov 15, 2019
@Rulox Rulox deleted the upstream-parameters branch November 15, 2019 12:03
@Rulox Rulox mentioned this pull request Nov 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow Setting Parameters (max_conns, etc.) through the YAML
3 participants
@Rulox @pleshakov @Dean-Coakley