Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helm tests on release tag #1255

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Nov 16, 2023

Fix Helm tests on release tag and replace cut commands.

Problem: Helm tests fail on release tag because the kind load command did not work when the provided images spanned multiple lines. Also, cut commands did not work as input was not a single value.

Solution: Instead of using steps.*.outputs.tags which can output multiple lines, changed to use the hardcoded path to the image and a specific version.

Testing: Manually verified on fork that the change works on a release tag.

Closes #1190

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug Something isn't working label Nov 16, 2023
@bjee19 bjee19 force-pushed the bug/helm-tests-fail-release-tag branch from 475971f to c3e8159 Compare November 16, 2023 22:40
@bjee19 bjee19 changed the title TESTING WORKFLOW, NOT READY: Change from using tags to hardcoded path and version Fix Helm tests on release tag Nov 17, 2023
@bjee19 bjee19 force-pushed the bug/helm-tests-fail-release-tag branch from 7aa78ee to 5c50d4a Compare November 17, 2023 19:44
@bjee19 bjee19 marked this pull request as ready for review November 17, 2023 19:45
@bjee19 bjee19 requested a review from a team as a code owner November 17, 2023 19:45
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bjee19 bjee19 force-pushed the bug/helm-tests-fail-release-tag branch from 9c443f2 to 6d0e48f Compare November 20, 2023 18:23
@bjee19 bjee19 merged commit 59dda24 into nginxinc:main Nov 20, 2023
23 checks passed
@bjee19 bjee19 deleted the bug/helm-tests-fail-release-tag branch May 7, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Helm tests fail on release tag
3 participants