Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some changes to workflow files #1276

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Nov 21, 2023

Some changes were made in PR #1255 that were incorrectly rebased.

Also, changed back to ngf-meta to keep things consistent with beforehand, should be identical since the line just grabs the version which should be the same.

@bjee19 bjee19 requested a review from a team as a code owner November 21, 2023 16:13
@github-actions github-actions bot added the bug Something isn't working label Nov 21, 2023
@sjberman sjberman added chore Pull requests for routine tasks and removed bug Something isn't working labels Nov 21, 2023
@sjberman
Copy link
Contributor

I tagged this as a chore instead of a bug, because it doesn't really make sense to show up in our release notes as a bug.

@bjee19 bjee19 merged commit bec359d into nginxinc:main Nov 21, 2023
21 of 23 checks passed
@bjee19 bjee19 deleted the bug/revert-error-from-conformance-file branch May 7, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants