-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry collection of deployment replica count #1551
Merged
bjee19
merged 8 commits into
nginxinc:main
from
bjee19:enh/telemetry-collect-deployment-replica-count
Feb 13, 2024
Merged
Add telemetry collection of deployment replica count #1551
bjee19
merged 8 commits into
nginxinc:main
from
bjee19:enh/telemetry-collect-deployment-replica-count
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjee19
commented
Feb 8, 2024
932eca2
to
ae1a21a
Compare
sjberman
reviewed
Feb 8, 2024
bjee19
commented
Feb 8, 2024
kate-osborn
reviewed
Feb 9, 2024
pleshakov
reviewed
Feb 9, 2024
kate-osborn
requested changes
Feb 9, 2024
b72bfb1
to
416f3f9
Compare
sjberman
approved these changes
Feb 12, 2024
kate-osborn
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggestion that I hope works this time, but I will also approve since the suggestion is not critical.
pleshakov
reviewed
Feb 12, 2024
pleshakov
reviewed
Feb 12, 2024
pleshakov
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
f53341e
to
8406a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Want to collect deployment replica count as a telemetry datapoint.
Solution: Collect deployment replica count.
Testing: E2E testing and additional unit tests.
When at 1 replica:
When scaled to 3 replicas:
Closes #1307
Checklist
Before creating a PR, run through this checklist and mark each as complete.