-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collects ClusterId for Telemetry Object Collector #1565
Collects ClusterId for Telemetry Object Collector #1565
Conversation
My PR on deployment replica count here is about to go in which will most likely cause some rebasing issues, I would prioritize getting that in then receiving feedback on this PR. |
c4494a8
to
fea9317
Compare
Be sure to update the PR description to include the issue to close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a couple small things!
Co-authored-by: Saylor Berman <s.berman@f5.com>
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀 good job
Proposed changes
ClusterID
for telemetry object.UID
associated withkube-system
namespace since it is unique and there is no concept of having a UID associated with cluster.Problem: Collect ClusterID for unique identification of NGF installations in a cluster
Solution: We will fetch the UID for
kube-system
namspace and use that as the clusterID for recognizing different installations of NGF in a cluster sincekube-system
will always exists and chances of UID collision are rare.Testing:
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1303
Checklist
Before creating a PR, run through this checklist and mark each as complete.