Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gatewayconfig crd #7

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Add gatewayconfig crd #7

merged 1 commit into from
Nov 15, 2021

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented Nov 13, 2021 •
edited

  • Add GatewayConfig CRD (includes the structs, generated code and manifests and the necessary tools for generation)
  • Add GatewayConfig Controller

Note - Group version is k8sgateway.nginx.org because code generation tools fail on k8s-gateway.nginx.org

@f5yacobucci
Copy link
Contributor

f5yacobucci commented Nov 15, 2021 •
edited

In response to your Note...is k8s redundant at this point? Just "gateway.nginx.org" is fine. Even if this is overly generic, it's only used as a value in k8s and I'm stretching my imagination to see where it would collide. If anything ran outside the cluster, we could name it "federated-gateway" or "gateway-control" for instance.

@pleshakov pleshakov merged commit c8c8023 into main Nov 15, 2021
@pleshakov pleshakov deleted the add-gatewayconfig-crd branch November 15, 2021 23:00
@pammecrandall pammecrandall added the enhancement New feature or request label Aug 9, 2022
@pleshakov pleshakov mentioned this pull request Aug 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f5yacobucci f5yacobucci f5yacobucci approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pleshakov @f5yacobucci @pammecrandall