-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run conformance tests in pod on cluster #787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Jun 26, 2023
sjberman
reviewed
Jun 26, 2023
kate-osborn
requested changes
Jun 26, 2023
kate-osborn
requested changes
Jun 26, 2023
pleshakov
reviewed
Jun 26, 2023
ciarams87
force-pushed
the
fix/run-tests-in-cluster
branch
from
June 26, 2023 22:40
7ca8d35
to
bc1fa81
Compare
ciarams87
force-pushed
the
fix/run-tests-in-cluster
branch
3 times, most recently
from
June 27, 2023 00:15
2ec828e
to
c42a185
Compare
ciarams87
force-pushed
the
fix/run-tests-in-cluster
branch
from
June 27, 2023 08:50
c42a185
to
ab25b5e
Compare
4 tasks
pleshakov
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits and consistency comments. otherwise, looks good!
sjberman
approved these changes
Jun 27, 2023
pleshakov
approved these changes
Jun 27, 2023
kate-osborn
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The conformance tests send traffic to the IPs of the NKG Pod for the corresponding Gateway. However, all tests that send traffic are failing with:
This is because we are running the tests in a Docker container on the local machine which cannot access the internal pod network.
Solution: Instead of running the tests in a Docker container, run the tests in a pod on the cluster. This also includes configuring RBAC for the appropriate CRUD access to the required resources. Additionally, the Makefile commands have been updated to preload the NGINX image to the local cluster, and to remove the requirement to manually edit the deployment manifests with the image under test.
Note: This PR adds a requirement for the utility yq to be installed locally - see https://github.com/mikefarah/yq.
Testing: Ran all commands locally. Tests are now passing traffic successfully.
Closes #771
Checklist
Before creating a PR, run through this checklist and mark each as complete.