Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a setup phase for external modules #71

Open
unode opened this issue Jun 13, 2018 · 0 comments
Open

Implement a setup phase for external modules #71

unode opened this issue Jun 13, 2018 · 0 comments
Assignees

Comments

@unode
Copy link
Member

unode commented Jun 13, 2018

When using external modules we currently provide an init phase in addition to the actual execution phase.
init can be used to test if all requirements to execute the module are satisfied.

On 8459d7e I've introduced a lock such that init could be used for concurrent unsafe operations such as install/build software. The lock however gets in the way of execution since several jobs will fight for the same lock. Even worse, if a job fails during this phase, other jobs will be waiting for 24h+.

The discussed solution is to implement a setup phase that will lock but would be skipped once successfully finished. Much like a makefile rule with a setup.done target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants