fix: add baseUrl input instead of assuming what it should be #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetanelBasal
reviewed
Jun 6, 2019
README.md
Outdated
| @@ -85,6 +85,8 @@ export class AppModule {} | |||
| | Input | Type | Default | Description | | |||
| | ------------------- | ------- | ----------------- | ------------------------------------------------- | | |||
| | animate | boolean | `true` | `false` to render with no animation | | |||
| | baseUrl | string | `` | Required if you're using `<base url="/" />` in your `<head/>`. Defaults to an empty string. This prop is commom used as: `<ContentLoader baseUrl={window.location.pathname} />` which will fill the svg attribute with the relative path. Related [#93](https://github.com/danilowoz/react-content-loader/issues/93). | |||
There was a problem hiding this comment.
Please change it to Angular component syntax.
added 2 commits
June 6, 2019 18:53
|
@alexw10 thanks. Could you please fix the README file? The table is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this mimics the change set here:
https://github.com/danilowoz/react-content-loader/pull/144/files
I think this is now more proper instead of assuming what the baseUrl should be for the applications we now have them pass it in.
I think this is a potential breaking change for applications so may want to make this a 3.0.0 version?
Will leave this up to you though.
Tested this in my companies application and it all now works properly.
Let me know if need anything further.