Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router Store: Refactor router_store_module into separate files #1298

Closed
brandonroberts opened this issue Aug 27, 2018 · 4 comments · Fixed by #1299
Closed

Router Store: Refactor router_store_module into separate files #1298

brandonroberts opened this issue Aug 27, 2018 · 4 comments · Fixed by #1299
Labels
Accepting PRs Project: Router Store

Comments

@brandonroberts
Copy link
Member

Describe any alternatives/workarounds you're currently using

Other information:

If accepted, I would be willing to submit a PR for this feature

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

The actions, reducer and module are all in one file.
@koumatsumoto
Copy link
Contributor

I'd like to submit pull request.

@brandonroberts
Copy link
Member Author

Ok, wait until #1294 lands or branch from there to get started

@koumatsumoto
Copy link
Contributor

Certainly, thank you.

@koumatsumoto koumatsumoto mentioned this issue Aug 27, 2018
Merged
3 tasks
brandonroberts pushed a commit that referenced this issue Aug 27, 2018
@koumatsumoto @brandonroberts
refactor(router-store): refactor router_store_module into separate fi…
17b8230 
…les (#1299)

Closes #1298
@timdeschryver
Copy link
Member

Well that was fast 🔥 🔥 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Project: Router Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(router-store): refactor router_store_module into separate files koumatsumoto/platform
3 participants
@brandonroberts @koumatsumoto @timdeschryver