refactor(router-store): refactor router_store_module into separate files #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
requested changes
Aug 27, 2018
| @@ -709,7 +709,9 @@ describe('Store Devtools', () => { | |||
| it('should add pause action', () => { | |||
| const liftedState = fixture.getLiftedState(); | |||
| expect(liftedState.nextActionId).toBe(4); | |||
| expect(liftedState.actionsById[3].action.type).toEqual('@ngrx/devtools/pause'); | |||
There was a problem hiding this comment.
Sorry, I reverted irrelevant files
| @@ -123,12 +123,12 @@ function recomputeStates( | |||
| const entry: ComputedState = shouldSkip | |||
| ? previousEntry | |||
| : computeNextEntry( | |||
| reducer, | |||
There was a problem hiding this comment.
@brandonroberts
I created a pull request to fix the indentations.
#1301
koumatsumoto
force-pushed
the
refactor-router-store-module-into-separate-files
branch
from
11ab77b to
b4e71d7
Compare
koumatsumoto
force-pushed
the
refactor-router-store-module-into-separate-files
branch
from
e824931 to
b13e48e
Compare
brandonroberts
approved these changes
Aug 27, 2018
koumatsumoto
deleted the
refactor-router-store-module-into-separate-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1298
What is the new behavior?
Divide code in router_store_module.ts into separate files.
Does this PR introduce a breaking change?
Other information
Closes #1298
yarn run prettierjust afteryarn.Some indentations are changed, but I used prettier@1.13.7 (latest for package.json).