-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Store-DevTools] Documentation: Example on excluding store-devtools in production build #1521
Labels
Accepting PRs
community watch
Someone from the community is working this issue/PR
Comp: Docs
Project: Store Devtools
Comments
This seems reasonable to me a recipe for Store Devtools |
brandonroberts
added
Project: Store Devtools
community watch
Someone from the community is working this issue/PR
labels
Feb 18, 2019
I'll try to get this done within 2 weeks. |
How can we do it using custom webpack configuration and not using angular-cli. |
@yorraksahb i would try it with the CopyWebpackPlugin |
Thank you |
EnricoVogt
added a commit
to EnricoVogt/platform
that referenced
this issue
Aug 17, 2019
2 tasks
EnricoVogt
added a commit
to EnricoVogt/platform
that referenced
this issue
Aug 19, 2019
EnricoVogt
added a commit
to EnricoVogt/platform
that referenced
this issue
Aug 21, 2019
brandonroberts
pushed a commit
that referenced
this issue
Aug 27, 2019
@yorraksahb you can also use |
jordanpowell88
added a commit
to jordanpowell88/platform
that referenced
this issue
Nov 8, 2019
ActionType is useful for extracting the response type of the new action creators. feat(store): add verbose error message for undefined feature state in development mode (ngrx#2078) Closes ngrx#1897 docs(store-devtools): add recipe to exclude store-devtools from the build (ngrx#2073) Closes ngrx#1521 fix(store): add DefaultProjectorFn to public API (ngrx#2090) Allows you to fully type the selector without reaching into the src folder ci: fix filters on tags for publishing to npm and deployment of docs (ngrx#2091) * refactor(data): use createEffect function instead of @effect decorator
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this issue
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Accepting PRs
community watch
Someone from the community is working this issue/PR
Comp: Docs
Project: Store Devtools
I followed examples in old repository issues to remove store-devtools from production build. When inspecting stats.json with webpack-bundle-inspector I noticed that it was still compiled in the main bundle.
ngrx.io or store-devtools README could include instructions on how to exclude module import in production. It's quite trivial and more related to angular itself but it's not obvious before you've seen it. Just google "typescript conditional import" and you get bucket full of confusion.
Add to
angular.json
under your production build.Where
build-specifics/index.prod.ts
is:Where
build-specifics/index.ts
is:On
app.module.ts
Other information:
Related wrong answer in old repository ngrx/store-devtools#53 (comment)
I would be willing to submit a PR for the docs ❤️
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered: