-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add verbose error message for unprovided feature state in development mode #2078
Merged
brandonroberts
merged 4 commits into
ngrx:master
from
jtcrowson:undefined-feature-state-error-message
Aug 27, 2019
Merged
feat(store): add verbose error message for unprovided feature state in development mode #2078
brandonroberts
merged 4 commits into
ngrx:master
from
jtcrowson:undefined-feature-state-error-message
Aug 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n development mode
Preview docs changes for ace90a5 at https://previews.ngrx.io/pr2078-ace90a5/ |
Preview docs changes for 068ed28 at https://previews.ngrx.io/pr2078-068ed28/ |
@jtcrowson will you add a test for this? |
@brandonroberts good call, added a unit test in fcabf12. |
Preview docs changes for fcabf12 at https://previews.ngrx.io/pr2078-fcabf12/ |
Preview docs changes for 36f8488 at https://previews.ngrx.io/pr2078-36f8488/ |
brandonroberts
approved these changes
Aug 27, 2019
jordanpowell88
added a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 8, 2019
ActionType is useful for extracting the response type of the new action creators. feat(store): add verbose error message for undefined feature state in development mode (ngrx#2078) Closes ngrx#1897 docs(store-devtools): add recipe to exclude store-devtools from the build (ngrx#2073) Closes ngrx#1521 fix(store): add DefaultProjectorFn to public API (ngrx#2090) Allows you to fully type the selector without reaching into the src folder ci: fix filters on tags for publishing to npm and deployment of docs (ngrx#2091) * refactor(data): use createEffect function instead of @effect decorator
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1897
What is the new behavior?
Verbose error message when the developer attemps to access a selector without first registering the state in a module.
In the example-app, if we try to get something from books state on the login page:
We get an error that accompanies the javascript "undefined" error that will help alert users to this common mistake:
Does this PR introduce a breaking change?
Other information