-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example: Clean up barrel imports #1684
Comments
i can pick this up? |
Sure |
@King-i are you still picking this up? |
Can we revisit barrel imports? What value do they add in the example app? |
Some kind of connected to this issue: What is your opinion on generating an index.ts file with schematics that exports a fromFeature namespace? This would lead to a better IDE experience in components, directives, services, modules that need to import reducers, actions, selectors, state. I can provide an example repo if you like this idea. |
The auth module has been refactored in #1808, you can use this a reference to refactor the books module. |
Is there anyone currently assigned this task? If not, I'd love the opportunity to jump in and help |
You can go ahead and take this one @jasonhodges, or are you currently working on this @King-i ? |
Thanks @timdeschryver |
No, we already have the community watch as label so we're all good. Maybe just wait 2-3 days before working on this, giving @King-i the opportunity to answer. |
No reply. I should be able to get started on this tomorrow. |
@brandonroberts @timdeschryver are there still other sections I can clean up barrel imports for? Thanks |
@jasonhodges I think the only one left is the |
Ok, I’ll take it 👍🏽 |
In multiple places we have individual imports for components, containers, effects.
index.ts
file in each grouping folder, for example (components/index.ts)index.ts
file, for example (export * from './login-page.component')The text was updated successfully, but these errors were encountered: