-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(example): use barrel import for auth module #1808
Conversation
Preview docs changes for 4e9954c at https://previews.ngrx.io/pr1808-4e9954c/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview docs changes for 4aff96c at https://previews.ngrx.io/pr1808-4aff96c/ |
Good point, I've add barrel imports to auth/models now. As for the array of components, IMHO that'd be too much for the amount of components the example app has. I imagine it could also be confusing for newcomers who are not used to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fyi, I have triggered another build for the failing docs
🤦♂️ because of the cleared cache, we now have the same build problem as in #1795 (comment) ( will be solved once #1795 gets merged) |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
related to #1684
What is the new behavior?
This PR introduces barrel imports for auth module and its sub-folders.
Does this PR introduce a breaking change?
Other information
While doing this change, I noticed some unused variables on auth specs. This PR also removes them. If this is not OK, I can issue a separate PR just for that.