Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated createFeature signature #3814

Closed
2 tasks
timdeschryver opened this issue Mar 28, 2023 · 2 comments · Fixed by #3825
Closed
2 tasks

Remove the deprecated createFeature signature #3814

timdeschryver opened this issue Mar 28, 2023 · 2 comments · Fixed by #3825
Labels
16.x Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Good First Issue Good issue for first-time contributor Project: Store

Comments

@timdeschryver
Copy link
Member

Which @ngrx/* package(s) are relevant/related to the feature request?

store

Information

Remove the deprecated createFeature signature.

This method was deprecated in #3737

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@apramendorfer
Copy link
Contributor

I could open a PR for this one aswell 😃

apramendorfer added a commit to apramendorfer/platform that referenced this issue Mar 30, 2023
@apramendorfer
feat(store): remove deprecated createFeature method
319f328 
Removes deprecated createFeature method accepting a root state parameter

Closes ngrx#3814
apramendorfer added a commit to apramendorfer/platform that referenced this issue Mar 30, 2023
@apramendorfer
feat(store): remove deprecated createFeature method
a6ba7a6 
Removes deprecated createFeature method accepting a root state parameter

Closes ngrx#3814
@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Mar 30, 2023
@timdeschryver
Copy link
Member Author

Just as a heads-up, these PRs will remain open until we start with our RC for v16.

@apramendorfer apramendorfer mentioned this issue Mar 31, 2023
Merged
3 tasks
brandonroberts pushed a commit that referenced this issue Apr 15, 2023
@apramendorfer
feat(store): remove deprecated createFeature method (#3825)
fd8f347 
Closes #3814 

BREAKING CHANGES:

The `createFeature` signature with root state is removed in favor of a signature without root state.
An automatic migration is added to remove this signature.

BEFORE:

```ts
interface AppState {
  users: State;
}

export const usersFeature = createFeature<AppState>({
  name: 'users',
  reducer: createReducer(initialState, /* case reducers */),
});
```

AFTER:

```ts
export const usersFeature = createFeature({
  name: 'users',
  reducer: createReducer(initialState, /* case reducers */),
});
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
16.x Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Good First Issue Good issue for first-time contributor Project: Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(store): remove deprecated createFeature method apramendorfer/platform
2 participants
@timdeschryver @apramendorfer