Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): remove deprecated createFeature method #3825

Merged

Conversation

apramendorfer
Copy link
Contributor

@apramendorfer apramendorfer commented Mar 31, 2023

Removes deprecated createFeature method accepting a root state parameter

Closes #3814

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3814

What is the new behavior?

The deprecated method createFeature is removed from store

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

Removes deprecated createFeature method accepting a root state parameter

Closes ngrx#3814
@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 274c489
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6433fb04272a7e0008f2d06e
😎 Deploy Preview https://deploy-preview-3825--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@apramendorfer
Copy link
Contributor Author

I have also removed the tests with passed app state type since they were using the createFeature method with a generic state type parameter.

@apramendorfer apramendorfer marked this pull request as ready for review March 31, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the deprecated createFeature signature
4 participants