docs: update events page with upcoming events, automatically move past events #1617

jtcrowson · 2019-03-13T07:12:42Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Events that have passed are in the upcoming section.
Missing upcoming events

Closes #1615

What is the new behavior?

Events automatically move from upcoming to past section after the date has passed.
Upcoming events added as requested in Docs: Update events page with upcoming events #1615

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

…e based on passing date

ngrxbot · 2019-03-13T07:22:03Z

Preview docs changes for 7b29f16 at https://previews.ngrx.io/pr1617-7b29f16/

ngrxbot · 2019-03-13T08:02:14Z

Preview docs changes for 79ebec6 at https://previews.ngrx.io/pr1617-79ebec6/

jtcrowson · 2019-03-13T15:59:17Z

This is a WIP. Please hold off reviewing.

ngrxbot · 2019-03-13T16:09:14Z

Preview docs changes for 63adf95 at https://previews.ngrx.io/pr1617-63adf95/

ngrxbot · 2019-03-13T16:34:38Z

Preview docs changes for 77dcca7 at https://previews.ngrx.io/pr1617-77dcca7/

ngrxbot · 2019-03-13T16:56:45Z

Preview docs changes for 315ab6a at https://previews.ngrx.io/pr1617-315ab6a/

timdeschryver · 2019-03-13T17:38:37Z

I'm going to update the title so it's clear that this is a WIP.

jtcrowson · 2019-03-13T18:57:14Z

@timdeschryver @brandonroberts do you know what I need to do to make my events.json file be hosted under /generated (https://previews.ngrx.io/pr1617-315ab6a/generated/events.json)? I don't see any special registration of contributors.json (https://previews.ngrx.io/pr1617-315ab6a/generated/contributors.json) or resources.json (https://previews.ngrx.io/pr1617-315ab6a/generated/resources.json)

timdeschryver · 2019-03-13T19:09:03Z

My guess would be projects\ngrx.io\tools\transforms\angular-content-package\index.js, I'm not 100% certain tho 😅

ngrxbot · 2019-03-13T19:19:26Z

Preview docs changes for 9ed378f at https://previews.ngrx.io/pr1617-9ed378f/

timdeschryver · 2019-03-13T19:33:14Z

Also add it to computePathsProcessor.pathTemplates = computePathsProcessor.pathTemplates.concat in the same file

ngrxbot · 2019-03-13T19:42:59Z

Preview docs changes for 3b5f1f6 at https://previews.ngrx.io/pr1617-3b5f1f6/

timdeschryver · 2019-03-13T22:31:32Z

Seems like it's showing up https://previews.ngrx.io/pr1617-3b5f1f6/generated/events.json 🎉

jtcrowson · 2019-03-14T00:41:28Z

@timdeschryver sure is, thanks for those suggestions 👏

ngrxbot · 2019-03-14T02:46:21Z

Preview docs changes for 6f9826b at https://previews.ngrx.io/pr1617-6f9826b/

ngrxbot · 2019-03-14T14:11:43Z

Preview docs changes for 0ea547a at https://previews.ngrx.io/pr1617-0ea547a/

ngrxbot · 2019-03-14T16:05:39Z

Preview docs changes for 3e3548c at https://previews.ngrx.io/pr1617-3e3548c/

ngrxbot · 2019-03-14T16:36:42Z

Preview docs changes for 97428fa at https://previews.ngrx.io/pr1617-97428fa/

ngrxbot · 2019-03-14T16:41:11Z

Preview docs changes for 1159e80 at https://previews.ngrx.io/pr1617-1159e80/

jtcrowson · 2019-03-14T17:03:22Z

@timdeschryver @brandonroberts ready for review 👍

brandonroberts

Thanks for all your work so far!

projects/ngrx.io/src/app/custom-elements/events/event.service.ts

projects/ngrx.io/content/marketing/events.json

projects/ngrx.io/src/app/custom-elements/events/event-list.component.spec.ts

projects/ngrx.io/src/app/custom-elements/events/event.model.ts

projects/ngrx.io/src/app/custom-elements/events/event.service.spec.ts

use spaces in test describe string, correct define model by ending in semi colon

projects/ngrx.io/content/marketing/events.json

timdeschryver

Two questions about the page:

Should we order the past events descending (from new to old)?
Should we make it more clear that the events are clickable? Or what about making the row clickable?

…tion into a pipe

ngrxbot · 2019-03-15T15:18:29Z

Preview docs changes for fc30ba5 at https://previews.ngrx.io/pr1617-fc30ba5/

jtcrowson · 2019-03-15T15:21:50Z

@timdeschryver

I think that sorting order makes the most sense.
I like the idea of making the rows clickable and maybe add a shadow on hover, somewhat similar to the resource list. I didn't realize the event names were clickable until I looked at the code 👀

Happy to take care of it in a follow-up design-oriented PR.

timdeschryver

LGTM

…t events (ngrx#1617) Closes ngrx#1615

ijz953 added 5 commits March 13, 2019 02:26

docs: update events page with upcoming events

6762089

docs: abstract events table into a component to prevent need to updat…

6a8ddfe

…e based on passing date

docs: Add events to the event-list events input

eed5049

docs: add tests for event-list component

4dcccc5

docs: improve formatting of event-list component

7b29f16

docs: fix event-list component tests

79ebec6

docs: moving events to json with service

63adf95

docs: adding debug info

315ab6a

jtcrowson force-pushed the update-ngrx-events branch from 77dcca7 to 315ab6a Compare March 13, 2019 16:48

timdeschryver changed the title ~~docs: update events page with upcoming events, automatically move past events~~ [WIP]: docs: update events page with upcoming events, automatically move past events Mar 13, 2019

docs: add events.json to index.js

9ed378f

docs: adding events.json to pathTemplates

3b5f1f6

docs: move date range and upcoming vs past logic into event service

6f9826b

jtcrowson force-pushed the update-ngrx-events branch from 44b2d83 to 6f9826b Compare March 14, 2019 00:44

docs: move observable into constructor

0ea547a

ijz953 added 2 commits March 14, 2019 11:31

docs: testing the event service

5939a05

docs: adding event list component tests

3e3548c

ijz953 added 3 commits March 14, 2019 12:22

docs: improving event list tests

518223b

docs: removing commented code

97428fa

docs: rename resourcesPath to eventsPath

1159e80

jtcrowson changed the title ~~[WIP]: docs: update events page with upcoming events, automatically move past events~~ docs: update events page with upcoming events, automatically move past events Mar 14, 2019

brandonroberts requested changes Mar 14, 2019

View reviewed changes

docs: pull request refactor

387753c

use spaces in test describe string, correct define model by ending in semi colon

timdeschryver reviewed Mar 14, 2019

View reviewed changes

projects/ngrx.io/content/marketing/events.json Outdated Show resolved Hide resolved

timdeschryver reviewed Mar 14, 2019

View reviewed changes

docs: refactor to use UTC YYYY-MM-DD format and moved date range func…

fc30ba5

…tion into a pipe

brandonroberts approved these changes Mar 15, 2019

View reviewed changes

timdeschryver approved these changes Mar 15, 2019

View reviewed changes

brandonroberts merged commit ea35472 into ngrx:master Mar 15, 2019

tja4472 pushed a commit to tja4472/platform that referenced this pull request Mar 20, 2019

docs: update events page with upcoming events, automatically move pas…

9ef5df7

…t events (ngrx#1617) Closes ngrx#1615

jtcrowson mentioned this pull request Apr 3, 2019

docs: order past events in descending order #1695

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: update events page with upcoming events, automatically move past events #1617

docs: update events page with upcoming events, automatically move past events #1617

jtcrowson commented Mar 13, 2019 •

edited

Loading

ngrxbot commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

jtcrowson commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

timdeschryver commented Mar 13, 2019

jtcrowson commented Mar 13, 2019 •

edited

Loading

timdeschryver commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

timdeschryver commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

timdeschryver commented Mar 13, 2019

jtcrowson commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

jtcrowson commented Mar 14, 2019

brandonroberts left a comment

timdeschryver left a comment

ngrxbot commented Mar 15, 2019

jtcrowson commented Mar 15, 2019

timdeschryver left a comment

docs: update events page with upcoming events, automatically move past events #1617

docs: update events page with upcoming events, automatically move past events #1617

Conversation

jtcrowson commented Mar 13, 2019 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

ngrxbot commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

jtcrowson commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

timdeschryver commented Mar 13, 2019

jtcrowson commented Mar 13, 2019 • edited Loading

timdeschryver commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

timdeschryver commented Mar 13, 2019

ngrxbot commented Mar 13, 2019

timdeschryver commented Mar 13, 2019

jtcrowson commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

ngrxbot commented Mar 14, 2019

jtcrowson commented Mar 14, 2019

brandonroberts left a comment

Choose a reason for hiding this comment

timdeschryver left a comment

Choose a reason for hiding this comment

ngrxbot commented Mar 15, 2019

jtcrowson commented Mar 15, 2019

timdeschryver left a comment

Choose a reason for hiding this comment

jtcrowson commented Mar 13, 2019 •

edited

Loading

jtcrowson commented Mar 13, 2019 •

edited

Loading