Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: order past events in descending order #1695

Merged
merged 3 commits into from
Apr 4, 2019

Conversation

jtcrowson
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Follow up to #1617

  • Upcoming events are in soonest to latest order (JSON ordering, not enforced)
  • Past events are in least recent to most recent order (JSON ordering, not enforced)

What is the new behavior?

Enforces ordering on the events page:

  • Upcoming events are in soonest to latest order (enforced)
  • Past events are in most recent to least recent order (enforced)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 3, 2019

Preview docs changes for d30bc4e at https://previews.ngrx.io/pr1695-d30bc4e/

import { Pipe, PipeTransform } from '@angular/core';
import { Event } from './event.model';

type EventOrderBy = 'earlierToLater' | 'laterToEarlier';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just 'ascending' and `descending'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 26275a5.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 4, 2019

Preview docs changes for 26275a5 at https://previews.ngrx.io/pr1695-26275a5/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 4, 2019

Preview docs changes for 6b9160b at https://previews.ngrx.io/pr1695-6b9160b/

@brandonroberts brandonroberts merged commit 45a5781 into ngrx:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants