Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: push node version up and refactor test #2190

Merged
merged 1 commit into from
Oct 31, 2019
Merged

build: push node version up and refactor test #2190

merged 1 commit into from
Oct 31, 2019

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bump up the node version
  • refactor the test that was funky (dealing with floating point calculations) and was failing with new node. Switch to test the compose fn instead of how JS deals with floating points.
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 30, 2019

Preview docs changes for 3cdfd71 at https://previews.ngrx.io/pr2190-3cdfd71/

@brandonroberts brandonroberts merged commit 025578a into ngrx:master Oct 31, 2019
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants